Change in vdsm[master]: stomp: use monotonic timer instead of clock

ybronhei at redhat.com ybronhei at redhat.com
Thu Feb 26 14:40:21 UTC 2015


Yaniv Bronhaim has posted comments on this change.

Change subject: stomp: use monotonic timer instead of clock
......................................................................


Patch Set 5: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/37056/5/lib/yajsonrpc/stomp.py
File lib/yajsonrpc/stomp.py:

Line 473:     def readable(self, dispatcher):
Line 474:         return True
Line 475: 
Line 476:     def _milis(self):
Line 477:         return int(round(elapsed_time() * 1000))
os.times()[4] returns in miliseconds already. please remove the * 1000
Line 478: 
Line 479: 
Line 480: class AsyncClient(object):
Line 481:     log = logging.getLogger("yajsonrpc.protocols.stomp.AsyncClient")


-- 
To view, visit https://gerrit.ovirt.org/37056
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I58fa9009c72422f28065282cdb3b5d20f010ec80
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list