Change in vdsm[ovirt-3.5]: vm: Fix LSM when using libvirt >= 1.2.8

ybronhei at redhat.com ybronhei at redhat.com
Thu Feb 26 13:50:50 UTC 2015


Yaniv Bronhaim has submitted this change and it was merged.

Change subject: vm: Fix LSM when using libvirt >= 1.2.8
......................................................................


vm: Fix LSM when using libvirt >= 1.2.8

Libvirt 1.2.8 introduced a regression where disk type is converted from
"block" to "file" after blockRebase. This breaks our extend logic, leading
to unwanted extension of up to the disk virtual size, practically making
it preallocated. In 3.5, this used to extend the disk without limit
using all free space on the vg.

Libvirt 1.2.9 introduced a new VIR_DOMAIN_BLOCK_REBASE_COPY_DEV flag
for fixing this issue. This flag must be used when calling blockRebase
with block-based disk. This fix was backported to EL7.1 in
libvirt-1.2.8-16.el7_1.1 and libvirt-python-1.2.8-6.el7_1.1.

This patch uses VIR_DOMAIN_BLOCK_REBASE_COPY_DEV when available, fixing
this issue in EL7.1 and Fedora 21. Other platforms are not affected by
this issue because they are running older libvirt versions.

We assume that we are always working with local libvirt daemon, and
having the flag in the libvirt python bindings means that libvirt daemon
support the flag.

Change-Id: Idf8a53db81b61378ca00ffb8bf069ae944b78db7
Bug-Url: https://bugzilla.redhat.com/1196049
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/38142
Reviewed-by: Eric Blake <eric.b.blake at gmail.com>
Reviewed-by: Adam Litke <alitke at redhat.com>
Reviewed-by: Francesco Romani <fromani at redhat.com>
Reviewed-by: Allon Mureinik <amureini at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/38201
Reviewed-by: Yaniv Bronhaim <ybronhei at redhat.com>
---
M vdsm/virt/vm.py
1 file changed, 11 insertions(+), 5 deletions(-)

Approvals:
  Nir Soffer: Verified
  Yaniv Bronhaim: Looks good to me, approved
  Allon Mureinik: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/38201
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idf8a53db81b61378ca00ffb8bf069ae944b78db7
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eric Blake <eric.b.blake at gmail.com>
Gerrit-Reviewer: Eyal Edri <eedri at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list