Change in vdsm[master]: tests: InterfaceSampleTests are failing with IOError

fromani at redhat.com fromani at redhat.com
Thu Feb 26 11:10:31 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: tests: InterfaceSampleTests are failing with IOError
......................................................................


Patch Set 8: Code-Review-1

well, I spoke too early :)

_read_password can be a module-private free function. Moreover, right now it lacks the 'self' argument (or @staticmethod, but no need for this)

-- 
To view, visit https://gerrit.ovirt.org/38113
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id1de7ed2222c9f531d490ffdd3f71a3130faf63b
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Madhu Pavan <kmp at linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list