Change in vdsm[master]: virt: Allocate additonal space for cow internal data
fromani at redhat.com
fromani at redhat.com
Thu Feb 26 10:26:33 UTC 2015
Francesco Romani has posted comments on this change.
Change subject: virt: Allocate additonal space for cow internal data
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
for some possibly irrational reasons 'getMaxVolumeSize' seems a bit misleading, but I don't have any better suggestions.
There is also floats, which IIRC are usually avoided, but I don't mind.
Logic seems OK, and the above reasons are not good enough for me to delay my +1, so here it comes.
https://gerrit.ovirt.org/#/c/38178/2/vdsm/virt/vmdevices/storage.py
File vdsm/virt/vmdevices/storage.py:
Line 51: VOLWM_FREE_PCT = 100 - config.getint('irs', 'volume_utilization_percent')
Line 52: VOLWM_CHUNK_REPLICATE_MULT = 2 # Chunk multiplier during replication
Line 53:
Line 54: # Estimate of the additional space needed for qcow format internal data.
Line 55: VOLWM_COW_OVERHEAD = 1.1
does it make sense to avoid floats here? We usually try to avoid them. I personally don't mind that much.
Line 56:
Line 57: def __init__(self, conf, log, **kwargs):
Line 58: if not kwargs.get('serial'):
Line 59: self.serial = kwargs.get('imageID'[-20:]) or ''
--
To view, visit https://gerrit.ovirt.org/38178
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I14ae7647e459e35d6b6aea632ad4ad9a3cf7666e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list