Change in vdsm[master]: tests: InterfaceSampleTests are failing with IOError
danken at redhat.com
danken at redhat.com
Thu Feb 26 10:08:51 UTC 2015
Dan Kenigsberg has posted comments on this change.
Change subject: tests: InterfaceSampleTests are failing with IOError
......................................................................
Patch Set 4: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/38113/4/tests/samplingTests.py
File tests/samplingTests.py:
Line 23: import os
Line 24: import tempfile
Line 25: import random
Line 26: import shutil
Line 27: import threading
please try to keep in alphabetic order (I see that it's already broken, but no need to break any further)
Line 28: import errno
Line 29:
Line 30: from vdsm import ipwrapper
Line 31: import virt.sampling as sampling
Line 154: with open(constants.P_VDSM_LIBVIRT_PASSWD) as passwd_file:
Line 155: return passwd_file.readline().rstrip("\n")
Line 156: except IOError as e:
Line 157: if e.errno == errno.ENOENT:
Line 158: return 'password'
There no real need to even attempt to read the password from file. it's useless for this test. returning 'password' should be enough.
Line 159:
Line 160: @MonkeyPatch(libvirtconnection, '_read_password', _read_password)
Line 161: @ValidateRunningAsRoot
Line 162: def testHostSampleReportsNewInterface(self):
--
To view, visit https://gerrit.ovirt.org/38113
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1de7ed2222c9f531d490ffdd3f71a3130faf63b
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Madhu Pavan <kmp at linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list