Change in vdsm[master]: vm: add 'name' property
danken at redhat.com
danken at redhat.com
Wed Feb 25 14:56:31 UTC 2015
Dan Kenigsberg has posted comments on this change.
Change subject: vm: add 'name' property
......................................................................
Patch Set 10: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/37824/10/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 3794: if dev['type'] == hwclass.GRAPHICS))
Line 3795:
Line 3796: @property
Line 3797: def name(self):
Line 3798: return self.conf['vmName'].encode('utf-8')
we should report vmName as unicode literal.
utf8 encoding was done to extract info from libvirt, and frankly - hsould have been hidden insilde supervdsm.
Line 3799:
Line 3800: def _getPid(self):
Line 3801: pid = '0'
Line 3802: try:
--
To view, visit https://gerrit.ovirt.org/37824
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic079c592c2758926e56ca337380d2e9b783dbcda
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list