Change in vdsm[master]: tests: move find() helper into testlib

fromani at redhat.com fromani at redhat.com
Wed Feb 25 09:55:53 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: tests: move find() helper into testlib
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/38152/1/tests/vmTests.py
File tests/vmTests.py:

Line 37: from vdsm import constants
Line 38: from vdsm import define
Line 39: from testlib import VdsmTestCase as TestCaseBase
Line 40: from testlib import permutations, expandPermutations
Line 41: from testlib import find
> find is too generic name for a library function - find_xml_element? testxml
right. I'll go for find_xml_element.

In a future patch, I'll reorganize xml test helpers into something like testxmllib (xmltestlib?).
Line 42: from testlib import make_config
Line 43: from testlib import XMLTestCase
Line 44: import caps
Line 45: import hooks


-- 
To view, visit https://gerrit.ovirt.org/38152
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6c09d49a33c9a6e617300190048a58d6cf2b0611
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list