Change in vdsm[master]: virt: make updateVolume a periodic operation
fromani at redhat.com
fromani at redhat.com
Tue Feb 24 13:28:52 UTC 2015
Francesco Romani has posted comments on this change.
Change subject: virt: make updateVolume a periodic operation
......................................................................
Patch Set 12:
(2 comments)
https://gerrit.ovirt.org/#/c/37594/12/vdsm/virt/periodic.py
File vdsm/virt/periodic.py:
Line 66: # access the storage, thus can block.
Line 67: Operation(
Line 68: VmDispatcher(
Line 69: cif,
Line 70: _executor,
this works, but it is a little ugly to keep repeating cif and _executor. Maybe cleanup leveraging functools.partial?
Can be done in a later patch.
Line 71: UpdateVolumes,
Line 72: _timeout_from(
Line 73: config.getint(
Line 74: 'irs', 'vol_size_sample_interval'))),
Line 229: def __call__(self):
Line 230: for vmDrive in self._vm.getDiskDevices():
Line 231: # TODO: If this block (it is actually possible?)
Line 232: # we must make sure we don't overwrite good data
Line 233: # with stale old data.
where should this override-avoidance check be placed?
--
To view, visit https://gerrit.ovirt.org/37594
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf5f4bff03acf4fb43eb6d296e4c02a6b7a52baa
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list