Change in vdsm[master]: RFE: Report downtime for each live migration

shavivi at redhat.com shavivi at redhat.com
Tue Feb 24 12:37:21 UTC 2015


Shahar Havivi has posted comments on this change.

Change subject: RFE: Report downtime for each live migration
......................................................................


Patch Set 4:

(2 comments)

https://gerrit.ovirt.org/#/c/37075/4/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 184: 
Line 185:     def __init__(self, vm):
Line 186:         AdvancedStatsThread.__init__(self, log=vm.log, daemon=True)
Line 187:         self._vm = vm
Line 188:         self._migDowntime = None
> no longer needed, it seems.
Done
Line 189: 
Line 190:         self.highWrite = (
Line 191:             AdvancedStatsFunction(
Line 192:                 self._highWrite,


Line 622:             # finishing.
Line 623:             stats['vmJobs'] = info
Line 624: 
Line 625:     def _getVmDownTime(self, stats):
Line 626:         if self._vm.actualDowntime is not None:
> could be moved into Vm class (like we do for watchdog)
Done
Line 627:             stats['migDowntime'] = self._vm.actualDowntime
Line 628: 
Line 629:     def get(self):
Line 630:         stats = {}


-- 
To view, visit https://gerrit.ovirt.org/37075
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I34260160404a2b3cc7d26f76a16cfa2385fa9017
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list