Change in vdsm[master]: NetDevice: lookup IP attributes using __getattr__
danken at redhat.com
danken at redhat.com
Mon Feb 23 16:41:12 UTC 2015
Dan Kenigsberg has posted comments on this change.
Change subject: NetDevice: lookup IP attributes using __getattr__
......................................................................
Patch Set 7: Code-Review-1
I do noyt see the benefit of implicit lookup for NetDevice items inside the IpConfig object.
I can already envisage someone setting
iface.ipv4 = something
and then wodering why iface.ipconfig.ipv4 is not changed.
--
To view, visit http://gerrit.ovirt.org/36715
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iecf268d557d642cb12a4b25d157ec059293a49c4
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
More information about the vdsm-patches
mailing list