Change in vdsm[master]: WIP: vm: drive: allow error policy fine tuning
fromani at redhat.com
fromani at redhat.com
Mon Feb 23 07:59:02 UTC 2015
Francesco Romani has posted comments on this change.
Change subject: WIP: vm: drive: allow error policy fine tuning
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/38009/1/tests/vmStorageTests.py
File tests/vmStorageTests.py:
Line 270: def test_set_supported_policy(self, policy):
Line 271: attrs = {}
Line 272: conf = drive_config(errorPolicy=policy)
Line 273: drive = Drive({}, self.log, **conf)
Line 274: drive._setDriverAttrErrorPolicy(attrs)
> Please do not test private methods. Change the design so it can be tested e
Right, this way is too fragile. I believe the simpler and correct thing to do is just to test the produced XML, then.
Line 275: self.assertEqual(attrs['error_policy'], policy)
Line 276:
Line 277: @permutations([[''], [None], [1], ['foobar']])
Line 278: def test_set_unsupported_policy(self, policy):
--
To view, visit http://gerrit.ovirt.org/38009
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b1234ab15fc87ad75dfeae197d058eec23accbc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list