Change in vdsm[master]: monitor: return whether the reported status is real

nsoffer at redhat.com nsoffer at redhat.com
Sun Feb 22 14:38:39 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: monitor: return whether the reported status is real
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.ovirt.org/#/c/37952/4/vdsm/storage/monitor.py
File vdsm/storage/monitor.py:

Line 170:         self.domain = None
Line 171:         self.sdUUID = sdUUID
Line 172:         self.hostId = hostId
Line 173:         self.interval = interval
Line 174:         self.nextStatus = Status(actual=False)
> I disagree, when it's being set here it's not an 'actual' status - only whe
nextStatus can never be non-actual, it is the status that will be stored when the next check is done.

I'm fine with setting it to None here. If you like to separate it to another patch, do it in a patch *before* this patch.
Line 175:         self.status = FrozenStatus(self.nextStatus)
Line 176:         self.isIsoDomain = None
Line 177:         self.isoPrefix = None
Line 178:         self.lastRefresh = time.time()


-- 
To view, visit http://gerrit.ovirt.org/37952
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1fea518991a76ea0f9ff1ff5258afe95bca2f00d
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Candace Sheremeta <cshereme at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list