Change in vdsm[master]: monitor: return whether the reported status is real

laravot at redhat.com laravot at redhat.com
Sun Feb 22 14:10:20 UTC 2015


Liron Aravot has posted comments on this change.

Change subject: monitor: return whether the reported status is real
......................................................................


Patch Set 4:

(4 comments)

http://gerrit.ovirt.org/#/c/37952/4//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2015-02-19 14:25:28 +0200
Line 4: Commit:     laravot at redhat.com <laravot at redhat.com>
Line 5: CommitDate: 2015-02-22 15:26:07 +0200
Line 6: 
Line 7: monitor: return whether the reported status is real
> is real -> is actual
Done
Line 8: 
Line 9: When the domain monitoring results are reported after the domain
Line 10: monitor was started. The first monitoring run may haven't been yet
Line 11: completed - which causes the returned status to be determined as OK


Line 14: It was attempted to change the inital returned status in the past but it
Line 15: broke the host activation flow in the engine (see change I8e0df) and
Line 16: therefore the inital results can't be changed (backward comptability) -
Line 17: therefore in this change i add a new info that indicates whether the
Line 18: reported status is actual or not.
> Can you describe why we need to know if the status is actual (e.g. how this
Done
Line 19: 
Line 20: Change-Id: I1fea518991a76ea0f9ff1ff5258afe95bca2f00d
Line 21: Bug-Url: https://bugzilla.redhat.com/1183977


http://gerrit.ovirt.org/#/c/37952/4/vdsm/rpc/vdsmapi-schema.json
File vdsm/rpc/vdsmapi-schema.json:

Line 1776: #
Line 1777: # @actual:     Indicates if the returned status is an actual monitoring result
Line 1778: #              or initial result that means that the first monitor run was not
Line 1779: #              yet completed
Line 1780: #              (new in version 4.16.12)
> Version?
see comment in the previous patch.
Line 1781: #
Line 1782: # Since: 4.10.0
Line 1783: # XXX: Add an enum for return codes and their meanings
Line 1784: ##


http://gerrit.ovirt.org/#/c/37952/4/vdsm/storage/monitor.py
File vdsm/storage/monitor.py:

Line 170:         self.domain = None
Line 171:         self.sdUUID = sdUUID
Line 172:         self.hostId = hostId
Line 173:         self.interval = interval
Line 174:         self.nextStatus = Status(actual=False)
> I written, there is no need to initialize self.status from self.nextStatus,
Please read my comment in the previous patch - this change isn't related to this patch - nextStatus before _monitorDomain is also a non actual status.
it can be initialized to None, but this is out of the scope of this change.
Line 175:         self.status = FrozenStatus(self.nextStatus)
Line 176:         self.isIsoDomain = None
Line 177:         self.isoPrefix = None
Line 178:         self.lastRefresh = time.time()


-- 
To view, visit http://gerrit.ovirt.org/37952
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1fea518991a76ea0f9ff1ff5258afe95bca2f00d
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Candace Sheremeta <cshereme at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list