Change in vdsm[master]: tests: Enhance ReadSpeed.testReadSpeedRegExp unit test

nsoffer at redhat.com nsoffer at redhat.com
Sun Feb 22 12:48:48 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: tests: Enhance ReadSpeed.testReadSpeedRegExp unit test
......................................................................


Patch Set 1:

(2 comments)

Nice, just refine the commit message and remove the trailing whitespace.

http://gerrit.ovirt.org/#/c/38021/1//COMMIT_MSG
Commit Message:

Line 13: the parameters in the template with the corresponding values from
Line 14: the output.
Line 15: 
Line 16: Instead, template removed and outputs, in the format returned by dd,
Line 17: are used now.
I don't think this explains very good why this change is better. Try to make this text little shorter and do not describe the change since we can see the change in the code.
Line 18: 
Line 19: Change-Id: Iec1eaa570729f8db2e00b19181b94daeedbce23b
Line 20: Signed-off-by: Ala Hino <ahino at redhat.com>


Line 17: are used now.
Line 18: 
Line 19: Change-Id: Iec1eaa570729f8db2e00b19181b94daeedbce23b
Line 20: Signed-off-by: Ala Hino <ahino at redhat.com>
Line 21: Bug-Url: https://bugzilla.redhat.com/1191549
> IIUC, this does not solve the bug, it's just related to it. If so, you shou
This is not even related to the bug, just general cleanup before we add a test for this bug.


-- 
To view, visit http://gerrit.ovirt.org/38021
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec1eaa570729f8db2e00b19181b94daeedbce23b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list