Change in vdsm[master]: virt: introduce support for periodic operations

fromani at redhat.com fromani at redhat.com
Fri Feb 20 15:42:13 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: virt: introduce support for periodic operations
......................................................................


Patch Set 10:

(1 comment)

notes to self

http://gerrit.ovirt.org/#/c/37593/10/vdsm/virt/periodic.py
File vdsm/virt/periodic.py:

Line 55: 
Line 56:     if _executor is None:
Line 57:         _executor = executor.Executor(name="periodic.Executor",
Line 58:                                       workers_count=_WORKERS,
Line 59:                                       max_tasks=_TASKS,
this is:
1. quite ugly
2. half backed.
Either this function creates and returns each time a new triplet (scheduler, executor, operations), or we move the creation above and here we just fill up operations.

And probably operations can be moved to globals as well, which is simpler to follow.
Line 60:                                       scheduler=_scheduler)
Line 61:         _executor.start()
Line 62: 
Line 63:     # this needs to be there to avoid to bind too early


-- 
To view, visit http://gerrit.ovirt.org/37593
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I834c067b1d3dba16a1f8c83e555d2cc04cbf32ed
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list