Change in vdsm[master]: network: api: allow removal of bond with no slaves

danken at redhat.com danken at redhat.com
Thu Feb 19 16:31:48 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: network: api: allow removal of bond with no slaves
......................................................................


network: api: allow removal of bond with no slaves

If we try to remove a bond with no slaves attached, VDSM explodes and
doesn't allow us to repair the network.

This patch moves checking of slaves up the stack, only to 'edit' and
'add' bond's functions.

'remove' bond function is able to objectivize slaveless bond and allows us
to remove it.

Change-Id: I8b472305c00e3f11a4f7ede78f84eea589ca616b
Signed-off-by: Petr Horáček <phoracek at redhat.com>
Bug-Url: https://bugzilla.redhat.com/1183728
Reviewed-on: http://gerrit.ovirt.org/37751
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M tests/functional/networkTests.py
M vdsm/network/api.py
M vdsm/network/models.py
3 files changed, 29 insertions(+), 4 deletions(-)

Approvals:
  Petr Horáček: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/37751
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8b472305c00e3f11a4f7ede78f84eea589ca616b
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list