Change in vdsm[master]: virt: make updateVolume a periodic operation

fromani at redhat.com fromani at redhat.com
Wed Feb 18 23:43:00 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: virt: make updateVolume a periodic operation
......................................................................


Patch Set 7:

(1 comment)

http://gerrit.ovirt.org/#/c/37594/7/vdsm/virt/periodic.py
File vdsm/virt/periodic.py:

Line 180:     def __call__(self):
Line 181:         if self._vm.isDisksStatsCollectionEnabled():
Line 182:             # Avoid queries from storage during recovery process
Line 183:             for vmDrive in self._vm.getDiskDevices():
Line 184:                 self._vm.updateDriveVolume(vmDrive)
> I was wondering why we need this in the first place.
Turns out we still need this. Performance drop due to per-VM dispatching seems manageable.


-- 
To view, visit http://gerrit.ovirt.org/37594
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idf5f4bff03acf4fb43eb6d296e4c02a6b7a52baa
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list