Change in vdsm[master]: v2v: fix wrong handling of errCode in get_external_vms

danken at redhat.com danken at redhat.com
Wed Feb 18 22:34:12 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: v2v: fix wrong handling of errCode in get_external_vms
......................................................................


v2v: fix wrong handling of errCode in get_external_vms

Opening connection via libvirt didn't return proper error code but
failed with exception.

Change-Id: Iac7a3d194704e05278fb84e4cc784f180becbf1f
Signed-off-by: Shahar Havivi <shaharh at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/37895
Tested-by: Shahar Havivi <shavivi at redhat.com>
Reviewed-by: Francesco Romani <fromani at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M lib/vdsm/define.py
M vdsm/API.py
M vdsm/v2v.py
3 files changed, 17 insertions(+), 9 deletions(-)

Approvals:
  Shahar Havivi: Verified
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Looks good to me, but someone else must approve



-- 
To view, visit http://gerrit.ovirt.org/37895
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iac7a3d194704e05278fb84e4cc784f180becbf1f
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list