Change in vdsm[master]: gluster: add _getDeviceDict function to reuse common code

danken at redhat.com danken at redhat.com
Wed Feb 18 18:07:50 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: gluster: add _getDeviceDict function to reuse common code
......................................................................


gluster: add _getDeviceDict function to reuse common code

Added internal function to return device dictonary which can be
used for storageDevicesList and any subsequent function.
Updated _canCreateBrick internal function to return False for
the device which type belongs to 'lvmthinlv'
Added device format uuid into storageDeviceList which was
missing in the existing function.

Change-Id: I25221e4266a4e14499c45916c5a4c9b723821bfb
Signed-off-by: Timothy Asir <tjeyasin at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/37643
Reviewed-by: Bala.FA <barumuga at redhat.com>
Reviewed-by: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M tests/glusterTestData.py
M vdsm/gluster/storagedev.py
2 files changed, 37 insertions(+), 32 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, but someone else must approve
  Timothy Asir: Verified
  Bala.FA: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/37643
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I25221e4266a4e14499c45916c5a4c9b723821bfb
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Ramesh N <rnachimu at redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list