Change in vdsm[master]: v2v: fix wrong handling of errCode in get_external_vms
danken at redhat.com
danken at redhat.com
Wed Feb 18 13:30:27 UTC 2015
Dan Kenigsberg has posted comments on this change.
Change subject: v2v: fix wrong handling of errCode in get_external_vms
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/37895/3/vdsm/v2v.py
File vdsm/v2v.py:
Line 45: conn = libvirtconnection.open_connection(uri=uri,
Line 46: username=username,
Line 47: passwd=password)
Line 48: except libvirt.libvirtError as e:
Line 49: logging.error('error connection to hypervisor: %r', e.message)
how about copying e.message to errCode["message"], so it is available in Engine logs?
Line 50: return errCode["V2VConnection"]
Line 51:
Line 52: with closing(conn):
Line 53: vms = []
--
To view, visit http://gerrit.ovirt.org/37895
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iac7a3d194704e05278fb84e4cc784f180becbf1f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list