Change in vdsm[master]: v2v: fix wrong handling of errCode in get_external_vms

shavivi at redhat.com shavivi at redhat.com
Wed Feb 18 12:06:52 UTC 2015


Shahar Havivi has posted comments on this change.

Change subject: v2v: fix wrong handling of errCode in get_external_vms
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.ovirt.org/#/c/37895/1/vdsm/v2v.py
File vdsm/v2v.py:

Line 38: 
Line 39: 
Line 40: def get_external_vms(uri, username, password):
Line 41:     if not supported():
Line 42:         return {'status': errCode["noimpl"]}
> oops. Somehow I've seen this change but not payed enough attention.
Done
Line 43: 
Line 44:     try:
Line 45:         conn = libvirtconnection.open_connection(uri=uri,
Line 46:                                                  username=username,


Line 46:                                                  username=username,
Line 47:                                                  passwd=password)
Line 48:     except libvirt.libvirtError as e:
Line 49:         logging.error('error connection to hypervisor: %r', e.message)
Line 50:         return {'status': errCode["V2VConnection"]}
> same, just use
Done
Line 51: 
Line 52:     with closing(conn):
Line 53:         vms = []
Line 54:         for vm in conn.listAllDomains():


-- 
To view, visit http://gerrit.ovirt.org/37895
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iac7a3d194704e05278fb84e4cc784f180becbf1f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list