Change in vdsm[master]: network: api: remove bond objectivization duplicated code
phoracek at redhat.com
phoracek at redhat.com
Wed Feb 18 07:48:07 UTC 2015
Petr Horáček has posted comments on this change.
Change subject: network: api: remove bond objectivization duplicated code
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/37750/2/vdsm/network/api.py
File vdsm/network/api.py:
Line 596: else:
Line 597: addition.append((name, attrs))
Line 598:
Line 599: def _getBondObject():
Line 600: bond = Bond.objectivize(name, configurator, attrs.get('options'),
> is it me or those 2 links are broken?
it's because of comma was considered as a part of url :D
- http://gerrit.ovirt.org/#/c/37754/
- http://gerrit.ovirt.org/#/c/37881/
Line 601: attrs.get('nics'), mtu=None, _netinfo=_netinfo,
Line 602: destroyOnMasterRemoval='remove' in attrs)
Line 603: return bond
Line 604:
--
To view, visit http://gerrit.ovirt.org/37750
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0dd75fa37a687dcd9b32519e075cf3efc7aa08e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list