Change in vdsm[master]: netinfo: Replacing xml.dom.minidom with lxml.etree module

danken at redhat.com danken at redhat.com
Tue Feb 17 14:12:39 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: netinfo: Replacing  xml.dom.minidom with lxml.etree module
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/37736/1/lib/vdsm/netinfo.py
File lib/vdsm/netinfo.py:

Line 29: import os
Line 30: import shlex
Line 31: import socket
Line 32: import struct
Line 33: from lxml import etree
please use

 import xml.etree.cElementTree as etree

we don't want a new out-of-stdlib dependency.
Line 34: 
Line 35: from . import constants
Line 36: from .ipwrapper import drv_name
Line 37: from .ipwrapper import DUMMY_BRIDGE


-- 
To view, visit http://gerrit.ovirt.org/37736
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If1a704cd53db56d64a3da6a056a322a6b35ee2bd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Genadi Chereshnya <gcheresh at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Meni Yakove <myakove at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list