Change in vdsm[master]: gluster.hostname: simplify by using a constant for the 'host...

danken at redhat.com danken at redhat.com
Tue Feb 17 10:44:31 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: gluster.hostname: simplify by using a constant for the 'hostname' executable
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/37621/1/vdsm/gluster/hostname.py
File vdsm/gluster/hostname.py:

Line 17: #
Line 18: # Refer to the README and COPYING files for full details of the license
Line 19: #
Line 20: 
Line 21: from vdsm import constants
It's very nice to drop hostname.py.in, but depending on the constants junkyard is also annoying.

Could you use CommandPath instead?
Line 22: from vdsm import utils
Line 23: 
Line 24: 
Line 25: class HostNameException(Exception):


-- 
To view, visit http://gerrit.ovirt.org/37621
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4b4a0062bedc41bee6528c1d06d707b4f7547e6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list