Change in vdsm[master]: network: api: remove bond objectivization duplicated code

danken at redhat.com danken at redhat.com
Mon Feb 16 15:56:31 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: network: api: remove bond objectivization duplicated code
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

http://gerrit.ovirt.org/#/c/37750/2/vdsm/network/api.py
File vdsm/network/api.py:

Line 596:         else:
Line 597:             addition.append((name, attrs))
Line 598: 
Line 599:     def _getBondObject():
Line 600:         bond = Bond.objectivize(name, configurator, attrs.get('options'),
I cannot say that I'm mad for this patch: this is a single function call (with gazillion arguments, of course).

But I see that you depend on this function in your follow-up patch http://gerrit.ovirt.org/#/c/37751/4/vdsm/network/api.py

what does Ido say?
Line 601:                                 attrs.get('nics'), mtu=None, _netinfo=_netinfo,
Line 602:                                 destroyOnMasterRemoval='remove' in attrs)
Line 603:         return bond
Line 604: 


-- 
To view, visit http://gerrit.ovirt.org/37750
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0dd75fa37a687dcd9b32519e075cf3efc7aa08e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list