Change in vdsm[master]: ifcfg: stop reading from NetDevice.ipConfig namedtuple in _g...

phoracek at redhat.com phoracek at redhat.com
Mon Feb 16 14:58:08 UTC 2015


Petr Horáček has posted comments on this change.

Change subject: ifcfg: stop reading from NetDevice.ipConfig namedtuple in _getIfaceConfValues
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/37793/3/vdsm/network/models.py
File vdsm/network/models.py:

Line 511:             self.ipv4.defaultRoute, self.ipv6.address, self.ipv6.gateway,
Line 512:             self.ipv6.defaultRoute, self.bootproto, self.async,
Line 513:             self.ipv6autoconf, self.dhcpv6, self.ipv4.default_route_ifcfg)
Line 514: 
Line 515:     def copy(self):
why don't use python's copy https://docs.python.org/2/library/copy.html
Line 516:         ipv4 = IPv4(self.ipv4.address, self.ipv4.netmask, self.ipv4.gateway,
Line 517:                     self.ipv4.defaultRoute)
Line 518:         ipv6 = IPv6(self.ipv6.address, self.ipv6.gateway,
Line 519:                     self.ipv6.defaultRoute)


-- 
To view, visit http://gerrit.ovirt.org/37793
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic72f387b45023527d14a17ba1b44b04d620243e2
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list