Change in vdsm[master]: Better logging for network restoration.
danken at redhat.com
danken at redhat.com
Sun Feb 15 16:38:03 UTC 2015
Dan Kenigsberg has posted comments on this change.
Change subject: Better logging for network restoration.
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/37506/1/vdsm/vdsm-restore-net-config
File vdsm/vdsm-restore-net-config:
Line 129: unified_restoration()
Line 130: else:
Line 131: ifcfg_restoration()
Line 132: except Exception as e:
Line 133: logging.error('%s restoration failed. error: %s',
Please use logging.exception which gives complete traceback and does not require an "e" variable
Line 134: 'unified' if unified else 'ifcfg',
Line 135: e)
Line 136: raise
Line 137: else:
--
To view, visit http://gerrit.ovirt.org/37506
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8dc4be51ec3f8af210f2b4a0acdc52e372835239
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list