Change in vdsm[master]: schema: require vmId in {Exited, Running}VmStats

danken at redhat.com danken at redhat.com
Sat Feb 14 21:41:03 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: schema: require vmId in {Exited,Running}VmStats
......................................................................


schema: require vmId in {Exited,Running}VmStats

On commit bb45b4b619c9a30a8fb35865fbd99f680295ac15
we were reminded in an harsh way that vmId must
always be present in the Vm.getStats() output.

One of the problems was that the vmId field was injected
the Vm.getStats() output by API.py, and this value was
not documented in the schema.

So, this patches update the schema to reflect the
reality of the Engine's needs.

Change-Id: Id4ac677f4321277fa274510c5a0b830b09e0b1bd
Related-To: https://bugzilla.redhat.com/1191405
Signed-off-by: Francesco Romani <fromani at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/37696
Reviewed-by: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M vdsm/rpc/vdsmapi-schema.json
1 file changed, 8 insertions(+), 3 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Verified



-- 
To view, visit http://gerrit.ovirt.org/37696
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id4ac677f4321277fa274510c5a0b830b09e0b1bd
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list