Change in vdsm[master]: packaging: debian: making code compatible with upstream M2Cr...

stirabos at redhat.com stirabos at redhat.com
Fri Feb 13 10:15:42 UTC 2015


Simone Tiraboschi has posted comments on this change.

Change subject: packaging: debian: making code compatible with upstream M2Crypto
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.ovirt.org/#/c/37746/4//COMMIT_MSG
Commit Message:

Line 11: https://github.com/M2Crypto/M2Crypto/blob/master/M2Crypto/SSL/Connection.py
Line 12: The method is indeed just a wrapper of the same method on the
Line 13: internal socket object.
Line 14: Using the method on the external class if available otherwise
Line 15: fall back and directly use it on the socket object.
> The commit message lie about the suggested behavior of the code.
Yes Nir, you are right: I wrote this when I though that was enough to call set timeout on the underling socket object, sadly it's not that easy.
And yes, fedora patch it's tweaking about blocking/non-blocking status depending on timeout value.

It's here:
http://pkgs.fedoraproject.org/cgit/m2crypto.git/tree/m2crypto-0.21.1-timeouts.patch
Line 16: 
Line 17: Change-Id: Id1808bc9e27dde72b018c3be413f5b2066127982


-- 
To view, visit http://gerrit.ovirt.org/37746
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id1808bc9e27dde72b018c3be413f5b2066127982
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Lev Veyde <lveyde at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list