Change in vdsm[master]: hostdev: display directed-passthrough status in caps

fromani at redhat.com fromani at redhat.com
Thu Feb 12 15:02:52 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: hostdev: display directed-passthrough status in caps
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.ovirt.org/#/c/37701/1//COMMIT_MSG
Commit Message:

Line 7: hostdev: display directed-passthrough status in caps
Line 8: 
Line 9: Whether the underlying host supports directed passthrough can be
Line 10: read via sysfs /sys/class/iommu, where support would be indicated
Line 11: by pressence of dma remapping indicator - dmarX (where X >= 0).
typo: double 's'
Line 12: This patch exposes this fact in caps via directedPassthrough key.
Line 13: 
Line 14: Change-Id: I159f49db4fdbfd347753b2c97c5f75b694ac9460


http://gerrit.ovirt.org/#/c/37701/1/vdsm/caps.py
File vdsm/caps.py:

Line 596:     return selinux
Line 597: 
Line 598: 
Line 599: def _getDirectedPassthrough():
Line 600:     return bool(len(os.listdir('/sys/class/iommu')))
silly comment:
  return bool(os.listdir('/sys/class/iommu'))
?

A bit more serious concern: in that directory, only dmarX files could be present or it is possible that something else
could wrongly be misinterpreted as dmarX?

Just asking, I do not really know yet about how the directory should look like
Line 601: 
Line 602: 
Line 603: def get():
Line 604:     targetArch = getTargetArch()


-- 
To view, visit http://gerrit.ovirt.org/37701
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I159f49db4fdbfd347753b2c97c5f75b694ac9460
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list