Change in vdsm[master]: virt: Fix limit when calculating next volume size

fromani at redhat.com fromani at redhat.com
Thu Feb 12 14:49:59 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: virt: Fix limit when calculating next volume size
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

patch seems fine. I wonder why this never exploded before. Or it did?

http://gerrit.ovirt.org/#/c/37726/1//COMMIT_MSG
Commit Message:

Line 5: CommitDate: 2015-02-11 19:16:51 +0200
Line 6: 
Line 7: virt: Fix limit when calculating next volume size
Line 8: 
Line 9: Drive.getNextVolumeSize limit was wrong, since Drive.truesize is using
that's scary!
Line 10: bytes and the result in in megabytes. We use safer naming convention now
Line 11: to avoid future confusion.
Line 12: 
Line 13: Change-Id: I4098dfc07184085e613f17b2c48d32e47888106c


-- 
To view, visit http://gerrit.ovirt.org/37726
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4098dfc07184085e613f17b2c48d32e47888106c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list