Change in vdsm[master]: hostdev: add hostdev device definition

fromani at redhat.com fromani at redhat.com
Thu Feb 12 14:35:49 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: hostdev: add hostdev device definition
......................................................................


Patch Set 2:

(1 comment)

seems OK at first glance but I'd like to spend a bit more time later.

http://gerrit.ovirt.org/#/c/37700/2/vdsm/virt/vmdevices/hostdevice.py
File vdsm/virt/vmdevices/hostdevice.py:

Line 1: from hostdev import detach_detachable
copyright boilerplate is missing. Let's make the lawyers happy and forget about it.
Line 2: from . import core
Line 3: from . import hwclass
Line 4: 
Line 5: 


-- 
To view, visit http://gerrit.ovirt.org/37700
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I51f6713cf76914d8626718071598421bc1731722
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list