Change in vdsm[master]: virt: Check if a drive is chuhked before extending

nsoffer at redhat.com nsoffer at redhat.com
Wed Feb 11 17:02:03 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: virt: Check if a drive is chuhked before extending
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.ovirt.org/#/c/37573/3/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 4776:         # the worst case, we'll need to extend 'base' to the same size as 'top'
Line 4777:         # plus a bit more to accomodate additional writes to 'top' during the
Line 4778:         # live merge operation.
Line 4779:         if drive.chunked:
Line 4780:             self.extendDriveVolume(drive, baseVolUUID, topSize)
> What happens for a chain with a RAW base volume and a cow snapshot?  Won't 
Before, we always called extend and in extendDriveVolume we use to skip the operation if Drive.blockDev was False.

Now we call this only when Drive.blockDev == True and format == "cow".

How can it lead to trying to extend a raw volume?
Line 4781: 
Line 4782:         # Trigger the collection of stats before returning so that callers
Line 4783:         # of getVmStats after this returns will see the new job
Line 4784:         self._vmStats.sampleVmJobs()


-- 
To view, visit http://gerrit.ovirt.org/37573
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I48416dde002272d45761296f176b97f4d870849d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list