Change in vdsm[master]: virt: Add Drive.chunked property

alitke at redhat.com alitke at redhat.com
Wed Feb 11 15:15:53 UTC 2015


Adam Litke has posted comments on this change.

Change subject: virt: Add Drive.chunked property
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.ovirt.org/#/c/37570/5/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 1407:         # FIXME: mergeCandidates should be a dictionary of candidate volumes
Line 1408:         # once libvirt starts reporting watermark information for all volumes.
Line 1409:         mergeCandidates = {}
Line 1410:         for drive in self._devices[hwclass.DISK]:
Line 1411:             if not drive.extendable:
chunked?  This is the first I've seen extendable.
Line 1412:                 continue
Line 1413: 
Line 1414:             capacity, alloc, physical = self._dom.blockInfo(drive.path, 0)
Line 1415:             ret.append((drive, drive.volumeID, capacity, alloc, physical))


-- 
To view, visit http://gerrit.ovirt.org/37570
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iedbb9ea5e708cc606def799a78f7089bc80f77c9
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list