Change in vdsm[master]: virt: add ExpiringCache

fromani at redhat.com fromani at redhat.com
Wed Feb 11 08:45:16 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: virt: add ExpiringCache
......................................................................


Patch Set 10:

(1 comment)

http://gerrit.ovirt.org/#/c/36716/10/vdsm/virt/utils.py
File vdsm/virt/utils.py:

Line 77: 
Line 78:     def __getitem__(self, key):
Line 79:         """
Line 80:         Raises KeyError if a key was not found.
Line 81:         Raises ItemExpired if a a key expired and was cleaned up.
> Still with double a? 
Damn, I missed the double 'a'. Also, will rephrase as you suggested.
Line 82:         ItemExpired is a subclass of KeyError.
Line 83:         """
Line 84:         return self._get_live(key)
Line 85: 


-- 
To view, visit http://gerrit.ovirt.org/36716
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I51e38cea6a23b7abe2375780e6ece0ff90831b6d
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list