Change in vdsm[master]: networkTests: remove a broken approach to unmanaging devices...

danken at redhat.com danken at redhat.com
Tue Feb 10 14:25:41 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: networkTests: remove a broken approach to unmanaging devices by NetworkManager
......................................................................


Patch Set 3:

(1 comment)

Please state with which NM versions the current code has been tested with.

http://gerrit.ovirt.org/#/c/37041/3//COMMIT_MSG
Commit Message:

Line 10: dnsmasq and dhclient on the respective sides) it was previously enough to set
Line 11: an address on the client side to stop NetworkManager from running its own
Line 12: dhclient on it.
Line 13: 
Line 14: Now this approach is useless. On the server side, NetworkManager automatically
Could you at least specify, for future reference, which NM versions have been tested with this patch?

el7 and f21's versions are mostly important
Line 15: takes the veth up, so we cannot even assign an address to it, and the test is
Line 16: skipped.
Line 17: 
Line 18: Let's remove the broken code now.


-- 
To view, visit http://gerrit.ovirt.org/37041
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idba14753bf9cd37ec1659a49ba7e13b9478f3913
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list