Change in vdsm[master]: v2v: additional info for disk and network

danken at redhat.com danken at redhat.com
Tue Feb 10 11:17:05 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: v2v: additional info for disk and network
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/37655/1/vdsm/v2v.py
File vdsm/v2v.py:

Line 132:     params['disks'] = []
Line 133:     disks = root.findall('.//disk[@type="file"]')
Line 134:     for disk in disks:
Line 135:         d = {}
Line 136:         d['type'] = disk.get('device')
Can 'device' ever be missing? We do NOT want to report None values over xmlrpc
Line 137:         target = disk.find('./target/[@dev]')
Line 138:         if target is not None:
Line 139:             d['dev'] = target.get('dev')
Line 140:         source = disk.find('./source/[@file]')


-- 
To view, visit http://gerrit.ovirt.org/37655
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id1ca59ac2396396b746768e539076ec2143bf6b7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list