Change in vdsm[master]: [wip] hornetq changes

ybronhei at redhat.com ybronhei at redhat.com
Mon Feb 9 18:59:43 UTC 2015


Yaniv Bronhaim has posted comments on this change.

Change subject: [wip] hornetq changes
......................................................................


Patch Set 1:

(4 comments)

http://gerrit.ovirt.org/#/c/36361/1//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2014-12-23 17:29:34 +0100
Line 4: Commit:     pkliczewski <piotr.kliczewski at gmail.com>
Line 5: CommitDate: 2014-12-23 17:31:44 +0100
Line 6: 
Line 7: [wip] hornetq changes
i don't understand how hornetq is being used here?..
Line 8: 
Line 9: 
Line 10: Change-Id: I9892acc1cf27055a381ce92ea95801250500e9ee


http://gerrit.ovirt.org/#/c/36361/1/lib/yajsonrpc/stompReactor.py
File lib/yajsonrpc/stompReactor.py:

Line 162: 
Line 163:     def reply(self, message, destination=_DEFAULT_RESPONSE_DESTINATION):
Line 164:         self.log.debug("Sending response")
Line 165:         if self._dest is not None:
Line 166:             destination = self._dest
its a bit weird to expect the function to use the parameter it gets but instead replace it with an attribute if exists..

what can set self._dest anyway?
Line 167:         res = stomp.Frame(stomp.Command.MESSAGE,
Line 168:                           {"destination": destination,
Line 169:                            "content-type": "application/json"},
Line 170:                           message)


http://gerrit.ovirt.org/#/c/36361/1/vdsm/clientIF.py
File vdsm/clientIF.py:

Line 85:         self.channelListener = Listener(self.log)
Line 86:         self._generationID = str(uuid.uuid4())
Line 87:         self.mom = None
Line 88:         self.bindings = {}
Line 89:         self._client = None
another client? what client?
Line 90:         if _glusterEnabled:
Line 91:             self.gluster = gapi.GlusterApi(self, log)
Line 92:         else:
Line 93:             self.gluster = None


Line 216:         reactor = json_binding.createStompReactor()
Line 217:         try:
Line 218:             from yajsonrpc import JsonRpcClient
Line 219:             stomp_client = reactor.createClient(
Line 220:                 self.create_socket('192.168.1.31', 61613))
what is this hard-coded address?
Line 221:             json_binding._onAccept(None, stomp_client)
Line 222:             self._client = JsonRpcClient(stomp_client, 'jms.queue.reponses',
Line 223:                                          'jms.queue.requests')
Line 224:         except:


-- 
To view, visit http://gerrit.ovirt.org/36361
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9892acc1cf27055a381ce92ea95801250500e9ee
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list