Change in vdsm[master]: gluster: volume snapshot config list and set verbs.

dnarayan at redhat.com dnarayan at redhat.com
Mon Feb 9 10:51:00 UTC 2015


Darshan N has posted comments on this change.

Change subject: gluster: volume snapshot config list and set verbs.
......................................................................


Patch Set 8:

(4 comments)

http://gerrit.ovirt.org/#/c/34741/8//COMMIT_MSG
Commit Message:

Line 11: 
Line 12: *glusterSnapshotConfigList: get the snapshot configuration.
Line 13: This verb gives the snapshot configuration for the cluster
Line 14: and for all the volumes present in it.
Line 15: Returns:
> Also in both the cases the outer level key shold be called "snapshotConfig"
Done
Line 16:     {'systemConfig':{'snap-max-hard-limit': 'hardLimit',
Line 17:                      'snap-max-soft-limit': 'softLimit',
Line 18:                      'auto-delete': 'enable/disable'},
Line 19:      'volumeConfig':{'volume name': {


Line 15: Returns:
Line 16:     {'systemConfig':{'snap-max-hard-limit': 'hardLimit',
Line 17:                      'snap-max-soft-limit': 'softLimit',
Line 18:                      'auto-delete': 'enable/disable'},
Line 19:      'volumeConfig':{'volume name': {
> How about 'system' instead of 'systemConfig' and 'volume' instead of 'volum
Done
Line 20:                           'snap-max-hard-limit': 'hardLimit'}...
Line 21:                     }
Line 22:     }
Line 23: 


Line 29:     {'systemConfig':{'snap-max-hard-limit': 'hardLimit',
Line 30:                      'snap-max-soft-limit': 'softLimit',
Line 31:                      'auto-delete': 'enable/disable'},
Line 32:      'volumeConfig':{'volume name': {
Line 33:                           'snap-max-hard-limit': 'hardLimit'}
> Here the value returned for snap-max-hard-limit should be value of "Effecti
As we discussed volume related config will provide snap-max-hard-limit, effective-hard-limit and snap-max-soft-limit.
Line 34:                     }
Line 35:     }
Line 36: 
Line 37: *glusterSnapshotConfigSet: Set snapshot configuration


http://gerrit.ovirt.org/#/c/34741/8/vdsm/rpc/vdsmapi-gluster-schema.json
File vdsm/rpc/vdsmapi-gluster-schema.json:

Line 1588:  'data': {},
Line 1589:  'returns': 'SnapConfigDetail'}
Line 1590: 
Line 1591: ##
Line 1592: # @GlusterVolumr.snapshotConfigList:
> spelling ?
Done
Line 1593: #
Line 1594: # get the config values of snapshot for a volume
Line 1595: #
Line 1596: # @volumeName: Gluster volume name


-- 
To view, visit http://gerrit.ovirt.org/34741
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee32a95cf028cda33f25776c08820c5ed80f1033
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list