Change in vdsm[master]: storageServer: Cleanup logging when mount fails

danken at redhat.com danken at redhat.com
Fri Feb 6 11:31:06 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: storageServer: Cleanup logging when mount fails
......................................................................


storageServer: Cleanup logging when mount fails

- Log the OSError text if os.rmdir fails instead of an unhelpful traceback
- Use logging.exception instead of exc_info=True
- Use "mountpoint" instead of "mount point"
- Use %r for revealing whitespace bugs in paths
- Unify logging messages

Change-Id: I24ae2c6ce71a1f20459977a8860dd6a1ebc45db3
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/36371
Reviewed-by: Allon Mureinik <amureini at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M vdsm/storage/storageServer.py
1 file changed, 4 insertions(+), 5 deletions(-)

Approvals:
  Nir Soffer: Verified
  Allon Mureinik: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/36371
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I24ae2c6ce71a1f20459977a8860dd6a1ebc45db3
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list