Change in vdsm[master]: storageServer: Fix connection error handling

danken at redhat.com danken at redhat.com
Fri Feb 6 11:28:59 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: storageServer: Fix connection error handling
......................................................................


storageServer: Fix connection error handling

We used to log a traceback and then raise the original error instance
(with a truncated traceback), which would cause another useless
traceback for the same error.

Now we keep the original exception info and re-raising it, so it is not
masked by errors raised during cleanup. Since we raise useful exception,
we don't need the additional log; having 2 tracebacks for same error is
not helping anyone.

Change-Id: I746cd71d065849dda7a2b53d7b74b53265a36b36
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/36331
Reviewed-by: Allon Mureinik <amureini at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M vdsm/storage/storageServer.py
1 file changed, 7 insertions(+), 6 deletions(-)

Approvals:
  Nir Soffer: Verified
  Allon Mureinik: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/36331
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I746cd71d065849dda7a2b53d7b74b53265a36b36
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list