Change in vdsm[master]: net_func_tests: Rollback only when an error happens
ibarkan at redhat.com
ibarkan at redhat.com
Wed Feb 4 06:15:32 UTC 2015
Ido Barkan has posted comments on this change.
Change subject: net_func_tests: Rollback only when an error happens
......................................................................
Patch Set 4: Verified+1
(1 comment)
http://gerrit.ovirt.org/#/c/29817/4/tests/functional/networkTests.py
File tests/functional/networkTests.py:
Line 415: netinfo = self.vdsm_net.netinfo
Line 416: self.assertIn(bondName, netinfo.bondings)
Line 417: self.assertEqual(netinfo.bondings[bondName]['active_slave'], '')
Line 418:
Line 419: @cleanupNet
> Does the fact that 'cleanupNet' is now on_exception_only=True by default (a
harmful it is not. it might be that there are tests the we either forgot to decorate or for got to un-decorate but in any case, it will be a no-op if an exception didn't occurre. I have verified that patch on on functional tests (an indeed found a few cases like this- testBrokenNetworkReplacement).
Another test that passed but left residue (and caused the failure of another test) was also fixed in a later patch.
Line 420: @RequireVethMod
Line 421: @ValidateRunningAsRoot
Line 422: def test_getVdsStats(self):
Line 423: """This Test will send an ARP request on a created veth interface
--
To view, visit http://gerrit.ovirt.org/29817
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaeb9bf19f4bf63d3705cfdda92aa6ec7513a8b98
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <toni at midokura.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list