Change in vdsm[master]: tests: 'ip link del dev <bridge>' fails on rhel6 if the brid...

danken at redhat.com danken at redhat.com
Tue Feb 3 15:20:31 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: tests: 'ip link del dev <bridge>' fails on rhel6 if the bridge device is still up.
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/37442/2/tests/functional/networkTests.py
File tests/functional/networkTests.py:

Line 1927:             status, msg = self.vdsm_net.setupNetworks(network, {},
Line 1928:                                                       NOCHK)
Line 1929:             self.assertEqual(status, SUCCESS, msg)
Line 1930:             self.assertNetworkExists(NETWORK_NAME)
Line 1931:             device_to_remove = NETWORK_NAME if bridged else nic + '.' + VLAN_ID
if bridged and _system_is_el6():
    execCmd([EXT_IFDOWN, NETWORK_NAME])

seems simpler
Line 1932:             try:
Line 1933:                 ipwrapper.linkDel(device_to_remove)
Line 1934:             except ipwrapper.IPRoute2Error:
Line 1935:                 if bridged and _system_is_el6():


-- 
To view, visit http://gerrit.ovirt.org/37442
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3e4921ee64cb36fef1a0658a991aa95b09e117cb
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list