Change in vdsm[master]: fix testBeforeNetworkSetupHook

danken at redhat.com danken at redhat.com
Tue Feb 3 15:13:27 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: fix testBeforeNetworkSetupHook
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.ovirt.org/#/c/37482/1/tests/functional/networkTests.py
File tests/functional/networkTests.py:

Line 1672:                 self.assertNetworkExists(NETWORK_NAME, bridged=True)
Line 1673: 
Line 1674:                 self.assertTrue(os.path.isfile(hook_cookiefile))
Line 1675: 
Line 1676:                 delete_networks = {NETWORK_NAME: {'remove': True}}
Please pass custom properties to delete, too.
Line 1677:                 self.vdsm_net.setupNetworks(delete_networks,
Line 1678:                                             {}, {})
Line 1679: 
Line 1680:     @cleanupNet


Line 1673: 
Line 1674:                 self.assertTrue(os.path.isfile(hook_cookiefile))
Line 1675: 
Line 1676:                 delete_networks = {NETWORK_NAME: {'remove': True}}
Line 1677:                 self.vdsm_net.setupNetworks(delete_networks,
add self.assertEqual(status, SUCCESS, msg)
Line 1678:                                             {}, {})
Line 1679: 
Line 1680:     @cleanupNet
Line 1681:     @ValidatesHook('after_network_setup', 'testAfterNetworkSetup.sh', True,


-- 
To view, visit http://gerrit.ovirt.org/37482
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0f8abb8cc592edc71280491c8025003b8c0770a9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Miguel Angel Ajo Pelayo <majopela at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list