Change in vdsm[master]: mkimage: more robust content signature

fromani at redhat.com fromani at redhat.com
Tue Feb 3 13:39:31 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: mkimage: more robust content signature
......................................................................


Patch Set 6:

(1 comment)

http://gerrit.ovirt.org/#/c/34203/6/vdsm/mkimage.py
File vdsm/mkimage.py:

Line 83:     sign.update(''.join(sorted(files.keys())))
Line 84:     # multiple valid base64 encoding exists for the same cleartext,
Line 85:     # so we must compute the sum on cleartext, not on cyphertext.
Line 86:     # See rhbz#1145636
Line 87:     for content in sorted(files.values()):
> What about the upgrade path? IIRC, the path has to be the same on source an
good point. And this alone makes this patch worthless. Too bad for the commit message, it was probably my best one to date.
Line 88:         sign.update(base64.b64decode(content))
Line 89:     return sign.hexdigest()
Line 90: 
Line 91: 


-- 
To view, visit http://gerrit.ovirt.org/34203
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id8dfd32eacd5c5a01d0ba27a8403a46d4bea02ab
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <toni at midokura.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list