Change in vdsm[master]: virt: move all_channels into DomainDescriptor

danken at redhat.com danken at redhat.com
Tue Feb 3 11:57:52 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: virt: move all_channels into DomainDescriptor
......................................................................


virt: move all_channels into DomainDescriptor

before the introduction of the DomainDescriptor
class, we had a bunch of functions/methods who
repeteadly parsed the VM XML Domain using the slow
minidom module.

The introduction of the DomainDescriptor opens
the gate for both more efficient and cleaner processing.

DomainDescriptor should provide methods to return
high-level objects, not low-level ones, e.g, XML document
nodes, which are inevitabily tied to the underlying xml
library being used.

The first step in this (long) journey is to move
vmxml.all_channels into the DomainDescriptor.
This allow us to have both nicer code in vm.Vm
and to save us one unneeded XML parsing.

Change-Id: I870cce435b2e26ff33cbd52f2421c1f3ce661707
Signed-off-by: Francesco Romani <fromani at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/34415
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M tests/vmXmlTests.py
M vdsm/virt/domain_descriptor.py
M vdsm/virt/vm.py
M vdsm/virt/vmxml.py
4 files changed, 45 insertions(+), 40 deletions(-)

Approvals:
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Verified



-- 
To view, visit http://gerrit.ovirt.org/34415
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I870cce435b2e26ff33cbd52f2421c1f3ce661707
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list