Change in vdsm[master]: hostdev: add support for reporting usb addresses

mpolednik at redhat.com mpolednik at redhat.com
Tue Feb 3 11:51:48 UTC 2015


Martin Polednik has posted comments on this change.

Change subject: hostdev: add support for reporting usb addresses
......................................................................


Patch Set 6:

(1 comment)

http://gerrit.ovirt.org/#/c/35785/6/vdsm/hostdev.py
File vdsm/hostdev.py:

Line 74:     also doing sysfs lookups for sr-iov related information
Line 75:     """
Line 76:     address_parser = {'pci': _parse_pci_address,
Line 77:                       'scsi': _parse_scsi_address,
Line 78:                       'usb_device': _parse_usb_address}
> why 'usb_device' and not just 'usb'?
This is a bit tricky: in terms of what libvirt reports, 'usb' itself is the bus and 'usb_device' is the thing we can passthrough - the end device. Therefore, we have to parse address of device which capabilities contain 'usb_device'.
Line 79: 
Line 80:     params = {}
Line 81: 
Line 82:     devXML = etree.fromstring(device_xml)


-- 
To view, visit http://gerrit.ovirt.org/35785
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3d4a4e1d3703abd25c9fa0584ec0e0a1d52b685c
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list