Change in vdsm[master]: netinfo: report a gateway for statically configured networks

ibarkan at redhat.com ibarkan at redhat.com
Mon Feb 2 08:08:34 UTC 2015


Ido Barkan has posted comments on this change.

Change subject: netinfo: report a gateway for statically configured networks
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/37440/1/lib/vdsm/netinfo.py
File lib/vdsm/netinfo.py:

Line 614:     # which the source route thread manages routing in a separate table (with
Line 615:     # an ID currently derived from the interface's address) we have to look in
Line 616:     # all tables.
Line 617:     gateways = [r for r in routes if r['destination'] == 'none' and
Line 618:                 (r.get('table') == table or dev) and r['scope'] == 'global' and
* formatting: this chained condition was hard to read even before (and now it's eye-breaking). Can you please rebase it on a reformatted code where each condition is in it's own line?
Line 619:                 r['family'] == ('inet6' if family == 6 else 'inet')]
Line 620:     try:
Line 621:         gateway, = gateways
Line 622:     except ValueError:


-- 
To view, visit http://gerrit.ovirt.org/37440
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I65b8c789cf393fbb9aa9d040c38d2c9d9f281864
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <toni at midokura.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list