Change in vdsm[master]: gluster: add createBrick verb
tjeyasin at redhat.com
tjeyasin at redhat.com
Mon Feb 2 07:11:27 UTC 2015
Timothy Asir has posted comments on this change.
Change subject: gluster: add createBrick verb
......................................................................
Patch Set 10:
(3 comments)
http://gerrit.ovirt.org/#/c/35498/10/vdsm/gluster/storagedev.py
File vdsm/gluster/storagedev.py:
Line 36:
Line 37:
Line 38: _pvcreateCommandPath = utils.CommandPath("pvcreate",
Line 39: "/sbin",
Line 40: "/usr/sbin/pvcreate",)
> No. I believe /usr/sbin, /sbin etc path only needed
yes, I got it, I will update the command path properly
Line 41: _lvconvertCommandPath = utils.CommandPath("lvconvert",
Line 42: "/sbin",
Line 43: "/usr/sbin/lvconvert",)
Line 44: _lvchangeCommandPath = utils.CommandPath("lvchange",
Line 61: FstabRecord = namedtuple("FstabRecord", "device mountPoint fsType "
Line 62: "mntOpts fsDump, fsPass")
Line 63:
Line 64:
Line 65: class FsTab(object):
> separate file
Done
Line 66: def __init__(self, fileName="/etc/fstab"):
Line 67: self.fileName = fileName
Line 68: self.devList = []
Line 69:
Line 64:
Line 65: class FsTab(object):
Line 66: def __init__(self, fileName="/etc/fstab"):
Line 67: self.fileName = fileName
Line 68: self.devList = []
> No. I think its better to have on demand listing which will help in dynami
Done
Line 69:
Line 70: def _list(self):
Line 71: self.devList = []
Line 72: with open(self.fileName, "r") as f:
--
To view, visit http://gerrit.ovirt.org/35498
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic47c4c56834deb457ae9d038f77bcf69c7b39ba5
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list