Change in vdsm[master]: gluster: add createBrick verb

tjeyasin at redhat.com tjeyasin at redhat.com
Mon Feb 2 06:16:06 UTC 2015


Timothy Asir has posted comments on this change.

Change subject: gluster: add createBrick verb
......................................................................


Patch Set 10:

(1 comment)

http://gerrit.ovirt.org/#/c/35498/10/vdsm/gluster/storagedev.py
File vdsm/gluster/storagedev.py:

Line 103:             raise ge.GlusterHostStorageDeviceFsTabEntryAlreadyFound(device)
Line 104:         content = open(self.fileName).read()
Line 105:         content += "UUID=%s\t%s\t%s\t%s\t%s\t%s\n" % (_getUuidByDevice(device),
Line 106:                                                       mountPoint, fsType,
Line 107:                                                       ",".join(mntOpts),
> I just followed vdsm way (storage.mount style) if it gives much value i wil
I tried but I feel it becomes very complicated also its not used anywhere right now. We will do it later if required
Line 108:                                                       fsDump, fsPass)
Line 109:         safeWrite(self.fileName, content)
Line 110: 
Line 111: 


-- 
To view, visit http://gerrit.ovirt.org/35498
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic47c4c56834deb457ae9d038f77bcf69c7b39ba5
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list